On Thu, Feb 18, 2021 at 7:28 AM Calvin Johnson <calvin.johnson@xxxxxxxxxxx> wrote: > > Define acpi_mdiobus_register() to Register mii_bus and create PHYs for > each ACPI child node. > +#include <linux/acpi.h> > +#include <linux/acpi_mdio.h> Perhaps it's better to provide the headers that this file is direct user of, i.e. bits.h dev_printk.h module.h types.h The rest seems fine because they are guaranteed to be included by acpi.h (IIUC about fwnode API and acpi_mdio includes MDIO PHY APIs). -- With Best Regards, Andy Shevchenko
