On Sat, Jan 23, 2021 at 4:25 PM Guenter Roeck <linux@xxxxxxxxxxxx> wrote: > > On Sat, Jan 23, 2021 at 07:21:04AM -0800, Guenter Roeck wrote: > > On Thu, Jan 21, 2021 at 04:23:51PM -0800, Erik Kaneda wrote: > > > From: Nick Desaulniers <ndesaulniers@xxxxxxxxxx> > > > > > > ACPICA commit 4b9135f5774caa796ddf826448811e8e7f08ef2f > > > > > > GCC 7.1 gained -Wimplicit-fallthrough to warn on implicit fallthrough, > > > as well as __attribute__((__fallthrough__)) and comments to explicitly > > > denote that cases of fallthrough were intentional. Clang also supports > > > this warning and statement attribute, but not the comment form. > > > > > > Robert Moore provides additional context about the lint comments being > > > removed. They were for "an old version of PC-Lint, which we don't use > > > anymore." Drop those. > > > > > > This will help us enable -Wimplicit-fallthrough throughout the Linux > > > kernel. > > > > > > Suggested-by: Robert Moore <robert.moore@xxxxxxxxx> > > > Reported-by: Jon Hunter <jonathanh@xxxxxxxxxx> > > > > > > Link: https://github.com/acpica/acpica/commit/4b9135f5 > > > Signed-off-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx> > > > Signed-off-by: Bob Moore <robert.moore@xxxxxxxxx> > > > Signed-off-by: Erik Kaneda <erik.kaneda@xxxxxxxxx> > > > > With gcc 6.5 (and presumably each gcc version older than 7.1), > > this patch results in: > > > > drivers/acpi/acpica/dscontrol.c: In function ‘acpi_ds_exec_begin_control_op’: > > drivers/acpi/acpica/dscontrol.c:65:3: error: ‘ACPI_FALLTHROUGH’ undeclared > > > > and similar errors for other files. > > > > Wait, this differs from the patch in -next. > > > > +#ifndef ACPI_FALLTHROUGH > > > +#define ACPI_FALLTHROUGH do {} while(0) > > This line is missing in -next. > > v2 doesn't say what changed in v2. Is that the change ? Yes, it is. It should appear in -next on Monday.
