On Wed, Jan 20, 2021 at 9:01 PM Saravana Kannan <saravanak@xxxxxxxxxx> wrote:
>
> On Wed, Jan 20, 2021 at 11:15 AM Rafael J. Wysocki <rafael@xxxxxxxxxx> wrote:
> >
> > On Wed, Jan 20, 2021 at 7:51 PM Andy Shevchenko
> > <andy.shevchenko@xxxxxxxxx> wrote:
> > >
> > > On Wed, Jan 20, 2021 at 8:18 PM Rafael J. Wysocki <rafael@xxxxxxxxxx> wrote:
> > > > On Tue, Jan 12, 2021 at 7:02 PM Andy Shevchenko
> > > > <andy.shevchenko@xxxxxxxxx> wrote:
> > > > > On Tue, Jan 12, 2021 at 09:30:31AM -0800, Saravana Kannan wrote:
> > > > > > On Tue, Jan 12, 2021 at 5:42 AM Calvin Johnson
> > > > > > <calvin.johnson@xxxxxxxxxxx> wrote:
> > >
> > > ...
> > >
> > > > > > > + ret = fwnode_property_read_u32(fwnode, "reg", id);
> > > > > > > + if (!(ret && is_acpi_node(fwnode)))
> > > > > > > + return ret;
> > > > > > > +
> > > > > > > +#ifdef CONFIG_ACPI
> > > > > > > + status = acpi_evaluate_integer(ACPI_HANDLE_FWNODE(fwnode),
> > > > > > > + METHOD_NAME__ADR, NULL, &adr);
> > > > > > > + if (ACPI_FAILURE(status))
> > > > > > > + return -EINVAL;
> > > > > > > + *id = (u32)adr;
> > > > > > > +#endif
> > > > > > > + return 0;
> > >
> > > > > > Also ACPI and DT
> > > > > > aren't mutually exclusive if I'm not mistaken.
> > > > >
> > > > > That's why we try 'reg' property for both cases first.
> > > > >
> > > > > is_acpi_fwnode() conditional is that what I don't like though.
> > > >
> > > > I'm not sure what you mean here, care to elaborate?
> > >
> > > I meant is_acpi_node(fwnode) in the conditional.
> > >
> > > I think it's redundant and we can simple do something like this:
> > >
> > > if (ret) {
> > > #ifdef ACPI
> > > ...
> > > #else
> > > return ret;
> > > #endif
> > > }
> > > return 0;
> > >
> > > --
> >
> > Right, that should work. And I'd prefer it too.
>
> Rafael,
>
> I'd rather this new function be an ops instead of a bunch of #ifdef or
> if (acpi) checks. Thoughts?
Well, it looks more like a helper function than like an op and I'm not
even sure how many potential users of it will expect that _ADR should
be evaluated in the absence of the "reg" property.
It's just that the "reg" property happens to be kind of an _ADR
equivalent in this particular binding AFAICS.
