> -----Original Message----- > From: Nick Desaulniers <ndesaulniers@xxxxxxxxxx> > Sent: Thursday, January 21, 2021 11:08 AM > To: Rafael J. Wysocki <rafael@xxxxxxxxxx>; Kaneda, Erik > <erik.kaneda@xxxxxxxxx> > Cc: Jon Hunter <jonathanh@xxxxxxxxxx>; Moore, Robert > <robert.moore@xxxxxxxxx>; Wysocki, Rafael J <rafael.j.wysocki@xxxxxxxxx>; > Gustavo A . R . Silva <gustavoars@xxxxxxxxxx>; clang-built-linux <clang-built- > linux@xxxxxxxxxxxxxxxx>; Len Brown <lenb@xxxxxxxxxx>; ACPI Devel > Maling List <linux-acpi@xxxxxxxxxxxxxxx>; open list:ACPI COMPONENT > ARCHITECTURE (ACPICA) <devel@xxxxxxxxxx>; Linux Kernel Mailing List > <linux-kernel@xxxxxxxxxxxxxxx>; linux-tegra <linux-tegra@xxxxxxxxxxxxxxx> > Subject: Re: [PATCH] ACPICA: fix -Wfallthrough > > On Thu, Jan 21, 2021 at 11:03 AM Rafael J. Wysocki <rafael@xxxxxxxxxx> > wrote: > > > > On Thu, Jan 21, 2021 at 11:08 AM Jon Hunter <jonathanh@xxxxxxxxxx> > wrote: > > > > > > > > > On 11/11/2020 02:11, Nick Desaulniers wrote: > > > > The "fallthrough" pseudo-keyword was added as a portable way to > denote > > > > intentional fallthrough. This code seemed to be using a mix of > > > > fallthrough comments that GCC recognizes, and some kind of lint > marker. > > > > I'm guessing that linter hasn't been run in a while from the mixed use > > > > of the marker vs comments. > > > > > > > > Signed-off-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx> > > > > > > > > > I know this is not the exact version that was merged, I can't find it on > > > the list, but looks like the version that was merged [0], > > > > It would be this patch: > > > > https://patchwork.kernel.org/project/linux- > acpi/patch/20210115184826.2250-4-erik.kaneda@xxxxxxxxx/ > > > > Nick, Erik? > > oh, shit, looks like a line was dropped. Here's what I sent upstream: > https://github.com/acpica/acpica/pull/650/files#diff- > cccd96e900e01f7224c81508cbddfb1af6fcfbff959d6bfb55123e1b9cad4e38R154 > 3 > Note in the patch Rafael links to that line is missing and there's > instead an #ifdef that's empty. Was this line accidentally dropped? Let me take a look... > > > > > > is causing build errors with older toolchains (GCC v6) ... > > > > > > /dvs/git/dirty/git-master_l4t- > upstream/kernel/drivers/acpi/acpica/dscontrol.c: In function > ‘acpi_ds_exec_begin_control_op’: > > > /dvs/git/dirty/git-master_l4t- > upstream/kernel/drivers/acpi/acpica/dscontrol.c:65:3: error: > ‘ACPI_FALLTHROUGH’ undeclared (first use in this function) > > > ACPI_FALLTHROUGH; > > > ^~~~~~~~~~~~~~~~ > > > /dvs/git/dirty/git-master_l4t- > upstream/kernel/drivers/acpi/acpica/dscontrol.c:65:3: note: each > undeclared identifier is reported only once for each function it appears in > > > /dvs/git/dirty/git-master_l4t- > upstream/kernel/scripts/Makefile.build:287: recipe for target > 'drivers/acpi/acpica/dscontrol.o' failed > > > > > > Cheers > > > Jon > > > > > > [0] https://github.com/acpica/acpica/commit/4b9135f5 > > > > > > -- > > > nvpublic > > > > -- > Thanks, > ~Nick Desaulniers
