ACPI thermal driver binds the devices listed in _TZD method with THERMAL_TRIPS_NONE.
Now given that
1. THERMAL_TRIPS_NONE is removed from thermal framework
2. _TZP is rarely supported. I searched ~500 acpidumps from different platforms reported by end users in kernel Bugzilla, there is only one platform with _TZP implemented, and it was almost 10 years ago.
So, I think it is safe to remove this piece of code.
> -----Original Message-----
> From: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
> Sent: Tuesday, January 05, 2021 11:44 PM
> To: Zhang, Rui <rui.zhang@xxxxxxxxx>
> Cc: mjg59@xxxxxxxxxxxx; linux-pm@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; amitk@xxxxxxxxxx; thara.gopinath@xxxxxxxxxx;
> Rafael J. Wysocki <rjw@xxxxxxxxxxxxx>; Len Brown <lenb@xxxxxxxxxx>; open
> list:ACPI THERMAL DRIVER <linux-acpi@xxxxxxxxxxxxxxx>
> Subject: Re: [PATCH 4/6] acpi/drivers/thermal: Remove TRIPS_NONE cooling
> device binding
> Importance: High
>
> Hi Rui,
>
>
> On 15/12/2020 00:38, Daniel Lezcano wrote:
> > The loop is here to create default cooling device binding on the
> > THERMAL_TRIPS_NONE number which is used to be the 'forced_passive'
> > feature. However, we removed all code dealing with that in the thermal
> > core, thus this binding does no longer make sense.
> >
> > Remove it.
> >
> > Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
Acked-by: Zhang Rui <rui.zhang@xxxxxxxxx>
Thanks,
rui
>
> Are you fine with this change?
>
> Thanks
>
> -- Daniel
>
> > ---
> > drivers/acpi/thermal.c | 19 -------------------
> > 1 file changed, 19 deletions(-)
> >
> > diff --git a/drivers/acpi/thermal.c b/drivers/acpi/thermal.c index
> > b5e4bc9e3282..26a89ff80a0e 100644
> > --- a/drivers/acpi/thermal.c
> > +++ b/drivers/acpi/thermal.c
> > @@ -764,25 +764,6 @@ static int acpi_thermal_cooling_device_cb(struct
> thermal_zone_device *thermal,
> > }
> > }
> >
> > - for (i = 0; i < tz->devices.count; i++) {
> > - handle = tz->devices.handles[i];
> > - status = acpi_bus_get_device(handle, &dev);
> > - if (ACPI_SUCCESS(status) && (dev == device)) {
> > - if (bind)
> > - result = thermal_zone_bind_cooling_device
> > - (thermal,
> THERMAL_TRIPS_NONE,
> > - cdev, THERMAL_NO_LIMIT,
> > - THERMAL_NO_LIMIT,
> > -
> THERMAL_WEIGHT_DEFAULT);
> > - else
> > - result =
> thermal_zone_unbind_cooling_device
> > - (thermal,
> THERMAL_TRIPS_NONE,
> > - cdev);
> > - if (result)
> > - goto failed;
> > - }
> > - }
> > -
> > failed:
> > return result;
> > }
> >
>
>
> --
> <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
>
> Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
> <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-
> blog/> Blog
