On Mon, Jan 4, 2021 at 3:55 PM Daniel Scally <djrscally@xxxxxxxxx> wrote: > On 04/01/2021 13:35, Kieran Bingham wrote: ... > +static const struct cio2_sensor_config cio2_supported_sensors[] = { > + /* Sensor OVTI5693 */ > + CIO2_SENSOR_CONFIG("INT33BE", 0), > + /* Sensor OVTI2680 */ > + CIO2_SENSOR_CONFIG("OVTI2680", 0), > > As an inline comment won't fit for the sensors that we know link-frequencies for. That sound ok? At least to me it looks okay. It seems for v5 we need Rafael's blessing on a few patches (driver properties / swnode / ACPI) and we are fine. -- With Best Regards, Andy Shevchenko