On Tue, Dec 29, 2020 at 2:07 AM Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> wrote: > On Tue, Dec 29, 2020 at 01:54:59AM +0200, Andy Shevchenko wrote: > > On Tue, Dec 29, 2020 at 1:08 AM Laurent Pinchart wrote: ... > > +#include <linux/videodev2.h> > > I think this can be dropped. I dropped above (I noticed it's included by a half of the headers listed below. > > +#include <media/media-device.h> > > +#include <media/media-entity.h> > > +#include <media/v4l2-async.h> > > +#include <media/v4l2-dev.h> > > +#include <media/v4l2-device.h> > > +#include <media/v4l2-subdev.h> > > +#include <media/videobuf2-core.h> > > +#include <media/videobuf2-v4l2.h> ... > How about grouping all forward declarations at the top ? Done. > Otherwise this looks good, > > Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> Thanks! I just sent a formal patch with your tag included. -- With Best Regards, Andy Shevchenko
