On Thu, Dec 24, 2020 at 3:12 AM Daniel Scally <djrscally@xxxxxxxxx> wrote:
>
> OF, ACPI and software_nodes all implement graphs including nodes for ports
> and endpoints. These are all intended to be named with a common schema,
> as "port@n" and "endpoint@n" where n is an unsigned int representing the
> index of the node. To ensure commonality across the subsystems, provide a
> set of macros to define the format.
Nitpicks below, but in general that's what I meant, thanks!
Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
(after addressing nitpicks)
> Suggested-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Signed-off-by: Daniel Scally <djrscally@xxxxxxxxx>
> ---
> Changes in v3
> - Patch introduced
>
> include/linux/fwnode.h | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/include/linux/fwnode.h b/include/linux/fwnode.h
> index 9506f8ec0974..52889efceb7d 100644
> --- a/include/linux/fwnode.h
> +++ b/include/linux/fwnode.h
> @@ -32,6 +32,19 @@ struct fwnode_endpoint {
> const struct fwnode_handle *local_fwnode;
> };
>
> +/*
> + * ports and endpoints defined in OF, ACPI and as software_nodes should all
> + * follow a common naming scheme; use these macros to ensure commonality across
> + * the subsystems.
> + *
> + * The *PREFIX_LEN macros refer to the length of the "port@" and "endpoint@"
*PREFIX_LEN -> *_PREFIX_LEN
> + * sections of the naming scheme.
> + */
> +#define FWNODE_GRAPH_PORT_NAME_FORMAT "port@%u"
> +#define FWNODE_GRAPH_PORT_NAME_PREFIX_LEN 5
> +#define FWNODE_GRAPH_ENDPOINT_NAME_FORMAT "endpoint@%u"
> +#define FWNODE_GRAPH_ENDPOINT_PREFIX_LEN 9
_FORMAT -> _FMT (however, V4L2 guys may correct me, because IIRC _FMT
suffix is also used for other things in v4l2.
> #define NR_FWNODE_REFERENCE_ARGS 8
>
> /**
--
With Best Regards,
Andy Shevchenko
