Hi, On 12/8/20 10:11 AM, Hans de Goede wrote: > Hi, > > On 12/7/20 8:29 PM, Rafael J. Wysocki wrote: >> On Thu, Dec 3, 2020 at 10:46 AM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: >>> >>> Hi, >>> >>> On 12/2/20 6:11 PM, Mark Pearson wrote: >>>> On modern systems the platform performance, temperature, fan and other >>>> hardware related characteristics are often dynamically configurable. The >>>> profile is often automatically adjusted to the load by some >>>> automatic-mechanism (which may very well live outside the kernel). >>>> >>>> These auto platform-adjustment mechanisms often can be configured with >>>> one of several 'platform-profiles', with either a bias towards low-power >>>> consumption or towards performance (and higher power consumption and >>>> thermals). >>>> >>>> Introduce a new platform_profile sysfs API which offers a generic API for >>>> selecting the performance-profile of these automatic-mechanisms. >>>> >>>> Co-developed-by: Mark Pearson <markpearson@xxxxxxxxxx> >>>> Signed-off-by: Mark Pearson <markpearson@xxxxxxxxxx> >>>> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> >>> >>> Thank you, patches 1 and 2 look good to me now, you may add my: >>> >>> Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx> >>> >>> To patch 2 (since I'm co-author of patch 1 it would be a bit weird >>> to add it there too). >>> >>> Rafael, it would be great if you pick up patches 1 and 2 for merging >>> into 5.11 (assuming that you agree that they are ready) then I will merge >>> patch 3 once 5.11-rc1 is out. >> >> I've applied patch [1/2] (as 5.11-rc material) for now, but I still >> needed to fix it up somewhat. Please check the result in my >> bleeding-edge branch. > > Thank you. > >> I'll get to the other patch tomorrow. > > The other patch likely conflicts with a bunch of other thinkpad_acpi > changes already in pdx86/for-next; and I still need to review v5 of > it, so please do not apply it. > > I will pick it up after 5.11-rc1 and send it out as part of a > pull-req for rc2. Sorry I misread what you wrote, when you said you "applied patch [1/2]", I now see that you have only merged: "[PATCH v5 1/3] Documentation: Add documentation for new platform_profile sysfs attribute" And that the other patch which you intend to merge is not the thinkpad_acpi patch but: "[PATCH v5 2/3] ACPI: platform-profile: Add platform profile support" So please ignore what I said before. ### I checked out the fixed up version of: "[PATCH v5 1/3] Documentation: Add documentation for new platform_profile sysfs attribute" Which you merged and it looks good to me, thanks. Regards, Hans
