On Mon, Dec 07, 2020 at 11:25:15AM -0800, Saravana Kannan wrote: > On Sat, Dec 5, 2020 at 11:26 PM Leon Romanovsky <leon@xxxxxxxxxx> wrote: > > > > On Fri, Nov 20, 2020 at 06:02:22PM -0800, Saravana Kannan wrote: > > > There are multiple locations in the kernel where a struct fwnode_handle > > > is initialized. Add fwnode_init() so that we have one way of > > > initializing a fwnode_handle. > > > > > > Signed-off-by: Saravana Kannan <saravanak@xxxxxxxxxx> > > > --- > > > drivers/acpi/property.c | 2 +- > > > drivers/acpi/scan.c | 2 +- > > > drivers/base/swnode.c | 2 +- > > > drivers/firmware/efi/efi-init.c | 8 ++++---- > > > include/linux/fwnode.h | 6 ++++++ > > > include/linux/of.h | 2 +- > > > kernel/irq/irqdomain.c | 2 +- > > > 7 files changed, 15 insertions(+), 9 deletions(-) > > > > In this series, I didn't find any extension of fwnode_init() to be it more > > than simple assignment. This change looks to me like unnecessary churn and > > obfuscation rather than improvement. > > > > "...ops = &...;" is pretty standard in the kernel to initialize ops > > structures. > > Subsequent patches make fwnode_init() do more stuff. But not in this series, right? Thanks > > -Saravana
