> -----Original Message----- > From: Hans de Goede <hdegoede@xxxxxxxxxx> > Sent: Thursday, October 29, 2020 2:49 AM > To: Kaneda, Erik <erik.kaneda@xxxxxxxxx>; Moore, Robert > <robert.moore@xxxxxxxxx>; Rafael J . Wysocki <rjw@xxxxxxxxxxxxx>; Len > Brown <lenb@xxxxxxxxxx> > Cc: linux-acpi@xxxxxxxxxxxxxxx; devel@xxxxxxxxxx > Subject: Re: [PATCH] ACPICA: Also handle "orphan" _REG methods for GPIO > OpRegions > > Hi, > > On 10/28/20 11:33 PM, Kaneda, Erik wrote: > > > > > >> -----Original Message----- > >> From: Hans de Goede <hdegoede@xxxxxxxxxx> > >> Sent: Tuesday, October 27, 2020 12:00 PM > >> To: Kaneda, Erik <erik.kaneda@xxxxxxxxx>; Moore, Robert > >> <robert.moore@xxxxxxxxx>; Rafael J . Wysocki <rjw@xxxxxxxxxxxxx>; Len > >> Brown <lenb@xxxxxxxxxx> > >> Cc: linux-acpi@xxxxxxxxxxxxxxx; devel@xxxxxxxxxx > >> Subject: Re: [PATCH] ACPICA: Also handle "orphan" _REG methods for > GPIO > >> OpRegions > >> > >> Hi, > >> > >> On 10/27/20 6:43 PM, Kaneda, Erik wrote: > >>> > >>> > >>>> -----Original Message----- > >>>> From: Moore, Robert <robert.moore@xxxxxxxxx> > >>>> Sent: Tuesday, October 27, 2020 7:17 AM > >>>> To: Kaneda, Erik <erik.kaneda@xxxxxxxxx>; Hans de Goede > >>>> <hdegoede@xxxxxxxxxx>; Rafael J . Wysocki <rjw@xxxxxxxxxxxxx>; > Len > >>>> Brown <lenb@xxxxxxxxxx> > >>>> Cc: linux-acpi@xxxxxxxxxxxxxxx; devel@xxxxxxxxxx > >>>> Subject: RE: [PATCH] ACPICA: Also handle "orphan" _REG methods for > >> GPIO > >>>> OpRegions > >>>> > >>>> Looks OK to me. > >>> > >>> Ok, I'll make a pull request of this to ACPICA on behalf of Hans and it will > be > >> in the next ACPICA release. > >> > >> Great, thank you. > > > > Pull request is available here: https://github.com/acpica/acpica/pull/644 > > > > Once it's merged, it'll be a part of the next ACPICA release. > > Thank you for porting this to the ACPICA upstream code, > unfortunately you missed one change when porting this. I've added > a review pointing the missing bit out on github. > > Specifically you missed this bit: > > if ((next_node->type == ACPI_TYPE_REGION) && > (next_node->object) && > - (next_node->object->region.space_id == > ACPI_ADR_SPACE_EC)) { > + (next_node->object->region.space_id == space_id)) { > goto exit; /* Do not execute the _REG */ > } > Updated the PR. Thanks for catching this, Erik > > Regards, > > Hans
