Hi, On 10/29/20 1:55 AM, Mark Pearson wrote: > Thanks Hans and Bastien, > > On 28/10/2020 13:23, Hans de Goede wrote: <big snip> >>> Is there another file which explains whether those sysfs value will >>> contain a trailing linefeed? >> >> sysfs APIs are typically created so that they can be used from the shell, >> so on read a newline will be added. On write a newline at the end >> typically is allowed, but ignored. There are even special helper functions >> to deal with properly ignoring the newline on write. >> >> Regards, >> >> Hans >> >> > OK - does that need to actually be specified here? Or is that just something I keep in mind for the implementation? IMHO it does not belong in the sysfs API docs for the platform_profile stuff. But I guess it would be good to document it somewhere in some generic syfs API rules/expectations document (with a note that their might be exceptions). Ideally we would already have such a file somewhere, but I don't know if we do (I did not look). So if you feel like it (and such a file does not exist yet) then I guess a patch adding such a doc file would be good. Regards, Hans
