From: Calvin Johnson <calvin.johnson@xxxxxxxxxxx> Date: Wed, 30 Sep 2020 21:34:25 +0530 > +struct phy_device *fwnode_phy_find_device(struct fwnode_handle *phy_fwnode) > +{ > + struct device *d; > + struct mdio_device *mdiodev; Please use reverse christmas tree ordering for local variables.