Re: [PATCH] ACPI: scan: Add braces around empty statements

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 24, 2020 at 1:37 PM Tian Tao <tiantao6@xxxxxxxxxxxxx> wrote:
>
> Fixes the following W=1 kernel build warning(s):
> drivers/acpi/scan.c: In function ‘acpi_bus_get_wakeup_device_flags’:
> drivers/acpi/scan.c:902:43: warning: suggest braces around empty body in
> an ‘if’ statement [-Wempty-body]
>
> Signed-off-by: Tian Tao <tiantao6@xxxxxxxxxxxxx>
> ---
>  drivers/acpi/scan.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
> index 2142f15..8340965 100644
> --- a/drivers/acpi/scan.c
> +++ b/drivers/acpi/scan.c
> @@ -897,9 +897,10 @@ static void acpi_bus_get_wakeup_device_flags(struct acpi_device *device)
>          * present will the _PSW object used.
>          */
>         err = acpi_device_sleep_wake(device, 0, 0, 0);
> -       if (err)
> +       if (err) {
>                 ACPI_DEBUG_PRINT((ACPI_DB_INFO,
>                                 "error in _DSW or _PSW evaluation\n"));
> +       }

Better replace ACPI_DEBUG_PRINT() with pr_debug().


Thanks!

>  }
>
>  static void acpi_bus_init_power_state(struct acpi_device *device, int state)
> --
> 2.7.4
>



[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux