On Tue, Sep 22, 2020 at 02:43:30PM -0700, Randy Dunlap wrote: > drivers/acpi/processor.ko uses rcu_idle_enter()/_exit() but > they are not exported. This causes build errors on IA64, > so export those 2 functions. > > ERROR: modpost: "rcu_idle_enter" [drivers/acpi/processor.ko] undefined! > ERROR: modpost: "rcu_idle_exit" [drivers/acpi/processor.ko] undefined! > > Reported-by: kernel test robot <lkp@xxxxxxxxx> > Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> > Cc: Rafael J. Wysocki <rjw@xxxxxxxxxxxxx> > Cc: linux-acpi@xxxxxxxxxxxxxxx > Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx> > Cc: Tony Luck <tony.luck@xxxxxxxxx> > Cc: Fenghua Yu <fenghua.yu@xxxxxxxxx> > Cc: linux-ia64@xxxxxxxxxxxxxxx > Cc: "Paul E. McKenney" <paulmck@xxxxxxxxxx> > Cc: Josh Triplett <josh@xxxxxxxxxxxxxxxx> > Cc: rcu@xxxxxxxxxxxxxxx > --- > Is there a problem with exporting these functions for use by > loadable modules? If so, this driver should be modified not > to use rcu_idle_enter/exit. Good catch, but Borislav Petkov beat you to it: https://lore.kernel.org/lkml/20200921103741.GC5901@xxxxxxx/ Rafael has applied Borislav's patch to his cpuidle tree for v5.9-rc7. Thanx, Paul > kernel/rcu/tree.c | 2 ++ > 1 file changed, 2 insertions(+) > > --- lnx-59-rc6.orig/kernel/rcu/tree.c > +++ lnx-59-rc6/kernel/rcu/tree.c > @@ -673,6 +673,7 @@ void rcu_idle_enter(void) > lockdep_assert_irqs_disabled(); > rcu_eqs_enter(false); > } > +EXPORT_SYMBOL_GPL(rcu_idle_enter); > > #ifdef CONFIG_NO_HZ_FULL > /** > @@ -886,6 +887,7 @@ void rcu_idle_exit(void) > rcu_eqs_exit(false); > local_irq_restore(flags); > } > +EXPORT_SYMBOL_GPL(rcu_idle_exit); > > #ifdef CONFIG_NO_HZ_FULL > /**
