On Mon, Sep 07, 2020 at 04:57:40PM +0300, Heikki Krogerus wrote: > From: Utkarsh Patel <utkarsh.h.patel@xxxxxxxxx> > > According to the PMC Type C Subsystem (TCSS) Mux programming guide rev > 0.7, bits 4 and 5 are reserved in Alternate modes. > SBU Orientation and HSL Orientation needs to be configured only during > initial cable detection in USB connect flow based on device property of > "sbu-orientation" and "hsl-orientation". > Configuring these reserved bits in the Alternate modes may result in delay > in display link training or some unexpected behaviour. > So do not configure them while issuing Alternate Mode requests. > > Fixes: ff4a30d5e243 ("usb: typec: mux: intel_pmc_mux: Support for static SBU/HSL orientation") > Signed-off-by: Utkarsh Patel <utkarsh.h.patel@xxxxxxxxx> > Signed-off-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx> Shouldn't this also need a cc:stable? And why not cc: the linux-usb list on these patches? thanks, greg k-h