On Mon, Sep 07, 2020 at 01:05:54PM +0200, Bartosz Golaszewski wrote: > On Fri, Sep 4, 2020 at 6:57 PM Andy Shevchenko > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > On Fri, Sep 04, 2020 at 05:45:40PM +0200, Bartosz Golaszewski wrote: > > > From: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx> > > > > > > This is in preparation for dynamically created chips. > > > > > > Let's split out the code that can be reused when creating chips at > > > run-time. Let's also move the code preparing the device properties into > > > a separate routine. This has the advantage of simplifying the error > > > handling. > > > > Almost all contents of this patch should go to proposed helper as I mentioned > > before. Will make this patch quite small and understandable. > Sorry, I'm not sure what you're referring to. I meant if you move changes done here to the patch where I complained about indentation you might have better series. Have you considered that? -- With Best Regards, Andy Shevchenko
