On Mon, Sep 07, 2020 at 01:01:02PM +0200, Bartosz Golaszewski wrote: > On Fri, Sep 4, 2020 at 6:48 PM Andy Shevchenko > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > On Fri, Sep 04, 2020 at 05:45:37PM +0200, Bartosz Golaszewski wrote: > > > From: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx> > > > > > > While we do check the "chip-name" property in probe(), we never actually > > > use it. Let's pass the chip label to the driver using device properties > > > as we'll want to allow users to define their own once dynamically > > > created chips are supported. > > > > > > The property is renamed to "chip-label" to not cause any confusion with > > > the actual chip name which is of the form: "gpiochipX". > > > > > > If the "chip-label" property is missing, let's do what most devices in > > > drivers/gpio/ do and use dev_name(). > > > > Just wondering if we have a documentation in kernel how this mockup mechanism > > works and what kind of properties it uses. > > > > Side note: moving to software nodes would make some advantages in future such > > as visibility properties and their values (not yet implemented, but there is an > > idea to move forward). > > Seems like we're implicitly using software nodes already: > fwnode_create_software_node() is called when adding device properties. It's not the same APIs, though the former is called from the latter. But maybe for now it's okay. -- With Best Regards, Andy Shevchenko
