On Thu, Sep 03, 2020 at 03:48:16PM +0300, Andy Shevchenko wrote: > On Thu, Sep 03, 2020 at 01:23:27PM +0200, Hans de Goede wrote: > the question is do we need to have similar in acpi_lpss.c? > For example, > static const struct lpss_device_desc byt_pwm_dev_desc = { > .flags = LPSS_SAVE_CTX, > ^^^^^^^^^^^^^^ > .prv_offset = 0x800, > .setup = byt_pwm_setup, > }; > > static const struct lpss_device_desc bsw_pwm_dev_desc = { > .flags = LPSS_SAVE_CTX | LPSS_NO_D3_DELAY, > ^^^^^^^^^^^^^^ > .prv_offset = 0x800, > .setup = bsw_pwm_setup, > }; Okay, it's a private space which has clock and reset gating, so means we still need to handle it. -- With Best Regards, Andy Shevchenko