On Sat, Aug 01, 2020 at 04:38:16PM +0200, Hans de Goede wrote: > On 7/29/20 12:54 PM, Andy Shevchenko wrote: > > On Fri, Jul 17, 2020 at 03:37:37PM +0200, Hans de Goede wrote: ... > > One comment to consider, though. There are three channels in that PWM AFAIU. > > One of them is backlight control, another one can be attached to haptics. The > > concern is how this series may (or may not?) affect haptics behaviour. > > When you say "in that PWM" do you mean the LPSS one or the CRC one ? CRC one. I have read it from PMIC spec, that's why the question. > The CRC PWM driver patches do make it honor the requested output frequency, > where before, because of a bug, it would stick with the out frequency > setup by the firmware (or the power-on-reset value if no value is set > by the firmware). This fix causing this is very clearly correct, but > it could have unexpected side-effects. -- With Best Regards, Andy Shevchenko
