Re: [PATCH] acpi: fix 'return' with no value build warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 31, 2020 at 5:39 AM Neal Liu <neal.liu@xxxxxxxxxxxx> wrote:
>
> Fixing CFI issue which introduced by commit efe9711214e6 is
> incomplete.
> Add return value to fix return-type build warning.
>
> Signed-off-by: Neal Liu <neal.liu@xxxxxxxxxxxx>

Applied with edited subject and changelog, but ->

> ---
>  drivers/acpi/processor_idle.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
> index 6ffb6c9..6870020 100644
> --- a/drivers/acpi/processor_idle.c
> +++ b/drivers/acpi/processor_idle.c
> @@ -664,11 +664,11 @@ static int acpi_idle_enter_s2idle(struct cpuidle_device *dev,
>                 struct acpi_processor *pr = __this_cpu_read(processors);
>
>                 if (unlikely(!pr))
> -                       return;
> +                       return -EFAULT;

-> there is no point returning an error code here, so I've made it
just return 0.

>
>                 if (pr->flags.bm_check) {
>                         acpi_idle_enter_bm(pr, cx, false);
> -                       return;
> +                       return 0;
>                 } else {
>                         ACPI_FLUSH_CPU_CACHE();
>                 }
> --



[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux