On Fri, Jul 10, 2020 at 7:31 PM Calvin Johnson <calvin.johnson@xxxxxxxxxxx> wrote: > > Introduce device_mdiobus_register() to register mdiobus > in cases of either DT or ACPI. ... > +/** > + * device_mdiobus_register - bring up all the PHYs on a given bus and > + * attach them to bus. This handles both DT and ACPI methods. I guess you can shrink this to fit one line. > + * @bus: target mii_bus > + * @dev: given MDIO device > + * > + * Description: Given an MDIO device and target mii bus, this function > + * calls of_mdiobus_register() for DT node and mdiobus_register() in > + * case of ACPI. > + * > + * Returns 0 on success or negative error code on failure. > + */ > +int device_mdiobus_register(struct mii_bus *bus, > + struct device *dev) It's a bit strange to have a function in device_* namespace to take a pointer to the struct device as not the first parameter... -- With Best Regards, Andy Shevchenko
