On Wed, Jul 8, 2020 at 8:35 PM Calvin Johnson <calvin.johnson@xxxxxxxxxxx> wrote: > > Store fwnode for mdiobus in the bus structure so that it can > later be retrieved and used whenever mdiobus fwnode information > is required. ... > + if (pdev->dev.fwnode) But do you need this check? > + bus->dev.fwnode = pdev->dev.fwnode; Shouldn't be rather something like dev_fwnode(). And maybe set_primary_fwnode()? I'm not sure about the latter, though. -- With Best Regards, Andy Shevchenko