On Wed, Jul 01, 2020 at 01:27:43PM +0300, Andy Shevchenko wrote:
> On Wed, Jul 1, 2020 at 9:13 AM Calvin Johnson
> <calvin.johnson@xxxxxxxxxxx> wrote:
> >
> > Introduce ACPI mechanism to get PHYs registered on a MDIO bus and
> > provide them to be connected to MAC.
> >
> > An ACPI node property "mdio-handle" is introduced to reference the
> > MDIO bus on which PHYs are registered with autoprobing method used
> > by mdiobus_register().
>
> ...
>
> > + Package (2) {"mdio-handle", Package (){\_SB.MDI0}}
>
> Reference as a package? Hmm... Is it really possible to have more than
> one handle here?
I didn't get your question here. Is it becasue of the (2)? I'll remove them
as they are automatically counted.
But if it is about the reference as a package. We've other similar examples.
One of them here:
https://github.com/tianocore/edk2-platforms/blob/master/Silicon/Hisilicon/Hi1610/Hi1610AcpiTables/Dsdt/D03Hns.asl#L581
>
> ...
>
> > + Package (2) {"phy-channel", 2},
> > + Package (2) {"phy-mode", "rgmii-id"},
> > + Package (2) {"mdio-handle", Package (){\_SB.MDI0}}
>
> And drop all these 2s. They are counted automatically by `iasl`.
>
Thanks
Calvin
