On 6/1/20 4:16 AM, Andrzej Pietrasiewicz wrote: > Hi Guenter, > > W dniu 29.05.2020 o 17:52, Guenter Roeck pisze: >> On Thu, May 28, 2020 at 09:20:46PM +0200, Andrzej Pietrasiewicz wrote: >>> Prepare for making the drivers not access tzd's private members. >>> >>> Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@xxxxxxxxxxxxx> > > <snip> > >>> + >> Nit: unnecessary empty line. >> >>> + return ret; > > <snip> > >>> + return thermal_zone_device_set_mode(tz, THERMAL_DEVICE_ENABLED); >>> +} >>> +EXPORT_SYMBOL(thermal_zone_device_enable); >> >> Other exports in thermal/ use EXPORT_SYMBOL_GPL. > > Other than that does it look good to you? Yes, it does. > I can send a v5 where the two above will be corrected, but did you have > a chance to review patches 7-11? > Not yet. I got distracted, sorry. Hopefully I'll get to it today or tomorrow. Guenter
