Re: [PATCH] drivers: GHES_ASSIST feature cause kernel to have a 5ms scheduling latency on AMD ROME's platform

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on pm/linux-next]
[also build test ERROR on v5.7-rc7 next-20200529]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/dianruihui-163-com/drivers-GHES_ASSIST-feature-cause-kernel-to-have-a-5ms-scheduling-latency-on-AMD-ROME-s-platform/20200601-002242
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
config: x86_64-rhel (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce (this is a W=1 build):
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>, old ones prefixed by <<):

drivers/acpi/apei/hest.c: In function 'hest_parse_ghes':
>> drivers/acpi/apei/hest.c:159:26: error: 'CPI_HEST_GHES_ASSIST_MSK' undeclared (first use in this function); did you mean 'ACPI_HEST_GHES_ASSIST_MSK'?
159 |      hest_hdr->source_id&CPI_HEST_GHES_ASSIST_MSK)
|                          ^~~~~~~~~~~~~~~~~~~~~~~~
|                          ACPI_HEST_GHES_ASSIST_MSK
drivers/acpi/apei/hest.c:159:26: note: each undeclared identifier is reported only once for each function it appears in

vim +159 drivers/acpi/apei/hest.c

   150	
   151	static int __init hest_parse_ghes(struct acpi_hest_header *hest_hdr, void *data)
   152	{
   153		struct platform_device *ghes_dev;
   154		struct ghes_arr *ghes_arr = data;
   155		int rc, i;
   156	
   157		if ((hest_hdr->type != ACPI_HEST_TYPE_GENERIC_ERROR &&
   158		    hest_hdr->type != ACPI_HEST_TYPE_GENERIC_ERROR_V2) ||
 > 159		    hest_hdr->source_id&CPI_HEST_GHES_ASSIST_MSK)
   160			return 0;
   161	
   162		if (!((struct acpi_hest_generic *)hest_hdr)->enabled)
   163			return 0;
   164		for (i = 0; i < ghes_arr->count; i++) {
   165			struct acpi_hest_header *hdr;
   166			ghes_dev = ghes_arr->ghes_devs[i];
   167			hdr = *(struct acpi_hest_header **)ghes_dev->dev.platform_data;
   168			if (hdr->source_id == hest_hdr->source_id) {
   169				pr_warn(FW_WARN HEST_PFX "Duplicated hardware error source ID: %d.\n",
   170					hdr->source_id);
   171				return -EIO;
   172			}
   173		}
   174		ghes_dev = platform_device_alloc("GHES", hest_hdr->source_id);
   175		if (!ghes_dev)
   176			return -ENOMEM;
   177	
   178		rc = platform_device_add_data(ghes_dev, &hest_hdr, sizeof(void *));
   179		if (rc)
   180			goto err;
   181	
   182		rc = platform_device_add(ghes_dev);
   183		if (rc)
   184			goto err;
   185		ghes_arr->ghes_devs[ghes_arr->count++] = ghes_dev;
   186	
   187		return 0;
   188	err:
   189		platform_device_put(ghes_dev);
   190		return rc;
   191	}
   192	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux