On Mon, May 18, 2020 at 4:59 PM Rafael J. Wysocki <rafael@xxxxxxxxxx> wrote: > > On Thu, May 14, 2020 at 12:10 PM Rafael J. Wysocki <rjw@xxxxxxxxxxxxx> wrote: > > > > From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx> > > > > Flushing the EC work while suspended to idle when the EC GPE status > > is not set causes some EC wakeup events (notably power button and > > lid ones) to be missed after a series of spurious wakeups on the Dell > > XPS13 9360 in my office. > > > > If that happens, the machine cannot be woken up from suspend-to-idle > > by a power button press or lid status change and it needs to be woken > > up in some other way (eg. by a key press). > > > > Flushing the EC work only after successful dispatching the EC GPE, > > which means that its status has been set, avoids the issue, so change > > the code in question accordingly. > > > > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx> > > --- > > > > Hi Chris, > > > > Please check if the key press wakeup still works on your system with this patch > > applied (on top of https://patchwork.kernel.org/patch/11538065/). > > Hi Chris, > > Since I haven't heard back from you and the problem at hand is a > regression on the machine where it happens, I'm going to push this > patch for merging. > > If it causes the key press wakeup issue to reappear on your machine, > I'm afraid that we'll need to quirk it in the EC driver. > > Thanks! > Sorry that I missed this email. I'll apply this patch and test again.
