Re: [PATCH v2] ACPI: IORT: Add extra message "applying workaround" for off-by-1 issue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 8 May 2020 at 06:07, Hanjun Guo <guohanjun@xxxxxxxxxx> wrote:
>
> As we already applied a workaround for the off-by-1 issue,
> it's good to add extra message "applying workaround" to make
> people less uneasy to see FW_BUG message in the boot log.
>
> Signed-off-by: Hanjun Guo <guohanjun@xxxxxxxxxx>
> ---
>
> v2:
>  - Print the extra message only for rid_in == map->input_base;
>  - Still based on top of for-next/acpi branch of ARM64 repo
>
>  drivers/acpi/arm64/iort.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c
> index b011d25..6e445bc 100644
> --- a/drivers/acpi/arm64/iort.c
> +++ b/drivers/acpi/arm64/iort.c
> @@ -332,6 +332,8 @@ static int iort_id_map(struct acpi_iort_id_mapping *map, u8 type, u32 rid_in,
>                        map, rid_in);
>                 if (rid_in != map->input_base)
>                         return -ENXIO;
> +
> +               pr_err(FW_BUG "applying workaround.\n");
>         }
>
>         *rid_out = map->output_base + (rid_in - map->input_base);
> --
> 1.7.12.4
>

Acked-by: Ard Biesheuvel <ardb@xxxxxxxxxx>



[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux