On Mon, Apr 27, 2020 at 02:58:20PM +0100, Russell King - ARM Linux admin wrote: > On Mon, Apr 27, 2020 at 06:54:06PM +0530, Calvin Johnson wrote: > > Following functions are defined: > > phylink_fwnode_phy_connect() > > phylink_device_phy_connect() > > fwnode_phy_find_device() > > device_phy_find_device() > > fwnode_get_phy_node() > > > > First two help in connecting phy to phylink instance. > > Next two help in finding a phy on a mdiobus. > > Last one helps in getting phy_node from a fwnode. > > > > Changes in v2: > > move phy code from base/property.c to net/phy/phy_device.c > > replace acpi & of code to get phy-handle with fwnode_find_reference > > replace of_ and acpi_ code with generic fwnode to get phy-handle. > > > > Calvin Johnson (3): > > device property: Introduce phy related fwnode functions > > net: phy: alphabetically sort header includes > > phylink: Introduce phylink_fwnode_phy_connect() > > Thanks for this, but there's more work that needs to be done here. I > also think that we must have an ack from ACPI people before this can be > accepted - you are in effect proposing a new way for representing PHYs > in ACPI. Thanks for your review. Agree that we need an ack from ACPI people. However, I don't think it is a completely new way as similar acpi approach to get phy-handle is already in place. Please see this: https://elixir.bootlin.com/linux/v5.7-rc3/source/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c#L832 Please let me know, if you see more work than the ones you pointed out in your review comments on previous patches. Thanks Calvin
