On Fri, Apr 24, 2020 at 12:54:26PM +0300, Andy Shevchenko wrote: > On Fri, Apr 24, 2020 at 12:27 PM Calvin Johnson > <calvin.johnson@xxxxxxxxxxx> wrote: > > On Thu, Apr 23, 2020 at 08:45:03PM -0700, Florian Fainelli wrote: > > > On 4/23/2020 8:16 PM, Calvin Johnson wrote: > > > > If you forget to update the MAINTAINERS file, or do not place this code > > > under drivers/net/phy/* or drivers/of/of_mdio.c then this is going to > > > completely escape the sight of the PHYLIB/PHYLINK maintainers... > > > > Did you mean the following change? > > I don't think this is an appreciated option. > Second one was to locate this code under drivers/net, which may be > better. And perhaps other not basic (to the properties) stuff should > be also moved to respective subsystems. How about placing it in drivers/net/phy/phy_device.c? If it is ok, I can do it in v2. Thanks Calvin