On Sat, Apr 18, 2020 at 2:41 PM Russell King - ARM Linux admin <linux@xxxxxxxxxxxxxxx> wrote: > On Sat, Apr 18, 2020 at 04:24:31PM +0530, Calvin Johnson wrote: > You seem to be duplicating the OF implementation in a private driver, > converting it to fwnode. This is not how we develop the Linux kernel. > We fix subsystem problems by fixing the subsystems, not by throwing > what should be subsystem code into private drivers. I didn't dive into the details, but I feel same way. -- With Best Regards, Andy Shevchenko