On Tue, Apr 14, 2020 at 02:08:42PM +0200, Hans de Goede wrote: > Hi, > > On 4/8/20 6:09 PM, Andy Shevchenko wrote: > > When I started looking into the intel_cht_int33fe driver for an example of use > > software node API, I have noticed that it's hard to get and code a bit messy. > > Here is a clean up, main part of which is to introduce node groups and API to > > register and unregister them. This and some pre-existing APIs can be used in > > the driver. > > > > So, because of cross-subsystem nature of this series, I may recommend to create > > myself the immutable branch which can be pulled to Rafael's and Greg's trees > > respectively. I'm also open for other proposals how to proceed. > > The series looks good to me and I've also tested it on one of > the devices using the intel_cht_int33fe driver and everything seems > to work fine, so for the whole series: > > Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx> > Tested-by: Hans de Goede <hdegoede@xxxxxxxxxx> Thank you, Hans! I'll wait for Greg and Rafael to conclude how to proceed with it and maybe for Heikki's response as well. > > Andy Shevchenko (6): > > device property: export set_secondary_fwnode() to modules > > software node: Allow register and unregister software node groups > > platform/x86: intel_cht_int33fe: Convert software node array to group > > platform/x86: intel_cht_int33fe: Convert to use set_secondary_fwnode() > > platform/x86: intel_cht_int33fe: Switch to use > > acpi_dev_hid_uid_match() > > platform/x86: intel_cht_int33fe: Fix spelling issues > > > > drivers/base/core.c | 1 + > > drivers/base/swnode.c | 48 ++++++++ > > .../platform/x86/intel_cht_int33fe_typec.c | 106 +++++++++--------- > > include/linux/property.h | 3 + > > 4 files changed, 108 insertions(+), 50 deletions(-) -- With Best Regards, Andy Shevchenko