> -----Original Message----- > From: Rafael J. Wysocki <rafael@xxxxxxxxxx> > Sent: Friday, April 3, 2020 2:24 AM > To: Jason Yan <yanaijie@xxxxxxxxxx>; Moore, Robert > <robert.moore@xxxxxxxxx>; Kaneda, Erik <erik.kaneda@xxxxxxxxx> > Cc: Wysocki, Rafael J <rafael.j.wysocki@xxxxxxxxx>; ACPI Devel Maling List > <linux-acpi@xxxxxxxxxxxxxxx>; open list:ACPI COMPONENT ARCHITECTURE > (ACPICA) <devel@xxxxxxxxxx> > Subject: [Devel] Re: [PATCH] ACPICA: make acpi_gbl_next_cmd_num static > > On Fri, Apr 3, 2020 at 8:48 AM Jason Yan <yanaijie@xxxxxxxxxx> wrote: > > > > Fix the following sparse warning: > > > > drivers/acpi/acpica/dbhistry.c:30:5: warning: symbol > > 'acpi_gbl_next_cmd_num' was not declared. Should it be static? > > > > Reported-by: Hulk Robot <hulkci@xxxxxxxxxx> > > Signed-off-by: Jason Yan <yanaijie@xxxxxxxxxx> > > Bob, Erik, I'm leaving this one to you. Hi Jason, This variable is being used in other parts of the code base so I made an adjustment here: https://github.com/acpica/acpica/pull/582 Once this pull request gets merged, we'll do a release and resubmit this change to Linux upstream. Thanks, Erik > > > --- > > drivers/acpi/acpica/dbhistry.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/acpi/acpica/dbhistry.c > > b/drivers/acpi/acpica/dbhistry.c index bb9600b867ee..801b35a08174 > > 100644 > > --- a/drivers/acpi/acpica/dbhistry.c > > +++ b/drivers/acpi/acpica/dbhistry.c > > @@ -27,7 +27,7 @@ static HISTORY_INFO > > acpi_gbl_history_buffer[HISTORY_SIZE]; > > static u16 acpi_gbl_lo_history = 0; > > static u16 acpi_gbl_num_history = 0; > > static u16 acpi_gbl_next_history_index = 0; > > -u32 acpi_gbl_next_cmd_num = 1; > > +static u32 acpi_gbl_next_cmd_num = 1; > > > > > /********************************************************** > ********************* > > * > > -- > > 2.17.2 > > > _______________________________________________ > Devel mailing list -- devel@xxxxxxxxxx > To unsubscribe send an email to devel- > leave@xxxxxxxxxx %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
