Hi Bjorn, >-----Original Message----- >From: Bjorn Helgaas [mailto:helgaas@xxxxxxxxxx] >Sent: 25 March 2020 15:22 >To: Shiju Jose <shiju.jose@xxxxxxxxxx> >Cc: linux-acpi@xxxxxxxxxxxxxxx; linux-pci@xxxxxxxxxxxxxxx; linux- >kernel@xxxxxxxxxxxxxxx; rjw@xxxxxxxxxxxxx; lenb@xxxxxxxxxx; bp@xxxxxxxxx; >james.morse@xxxxxxx; tony.luck@xxxxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx; >zhangliguang@xxxxxxxxxxxxxxxxx; tglx@xxxxxxxxxxxxx; Linuxarm ><linuxarm@xxxxxxxxxx>; Jonathan Cameron ><jonathan.cameron@xxxxxxxxxx>; tanxiaofei <tanxiaofei@xxxxxxxxxx>; >yangyicong <yangyicong@xxxxxxxxxx> >Subject: Re: [PATCH v5 0/2] ACPI: APEI: Add support to notify the vendor >specific HW errors > >1) If you can post things as a series, i.e., with patch 1/2 and patch >2/2 being responses to the 0/2 cover letter, that makes things easier. >It looks like you did this for the previous postings. I will send the patches as series after fixing the issues in the patch subject lines. > >2) When applying these, "git am" complained (but they did apply >cleanly): > > warning: Patch sent with format=flowed; space at the end of lines might be >lost. > Applying: APEI: Add support to notify the vendor specific HW errors > warning: Patch sent with format=flowed; space at the end of lines might be >lost. > Applying: PCI: HIP: Add handling of HiSilicon HIP PCIe controller errors > >3) drivers/pci/controller/pcie-hisi-error.c should be next to >drivers/pci/controller/dwc/pcie-hisi.c, shouldn't it? Our hip PCIe controller doesn't use DWC ip. > >4) Your subject lines don't match the convention. "git log --oneline >drivers/acpi/apei" says: > > 011077d8fbfe ("APEI: Add support to notify the vendor specific HW errors") > cea79e7e2f24 ("apei/ghes: Do not delay GHES polling") > 933ca4e323de ("acpi: Use pr_warn instead of pr_warning") > 6abc7622271d ("ACPI / APEI: Release resources if gen_pool_add() fails") > bb100b64763c ("ACPI / APEI: Get rid of NULL_UUID_LE constant") > 371b86897d01 ("ACPI / APEI: Remove needless __ghes_check_estatus() >calls") > >and "git log --oneline --follow drivers/pci/controller/dwc/pcie-hisi*" >says: > > 6e0832fa432e ("PCI: Collect all native drivers under drivers/pci/controller/") > 8cfab3cf63cf ("PCI: Add SPDX GPL-2.0 to replace GPL v2 boilerplate") > 5a4751680189 ("PCI: hisi: Constify dw_pcie_host_ops structure") > b379d385bbaa ("PCI: hisi: Remove unused variable driver") > a5f40e8098fe ("PCI: Don't allow unbinding host controllers that aren't >prepared") > e313a447e735 ("PCI: hisi: Update PCI config space remap function") > b9c1153f7a9c ("PCI: hisi: Fix DT binding (hisi-pcie-almost-ecam)") > >So your subject lines should be: > > ACPI / APEI: ... Sure. I will fix this. > PCI: hisi: ... Can we use PCI: hip because this driver is for the HIP hardware devices. [...] >> -- >> 2.17.1 Thanks, Shiju
