On Sat, Feb 29, 2020 at 09:57:52PM +0100, Hans de Goede wrote: > On 2/28/20 12:22 PM, Hans de Goede wrote: > > On 2/25/20 1:57 PM, Andy Shevchenko wrote: > > > On Tue, Feb 25, 2020 at 02:34:25PM +0200, Andy Shevchenko wrote: > > > > On Tue, Feb 25, 2020 at 12:26:04PM +0100, Hans de Goede wrote: > > > > > > > Let's do it as a list of pairs, but in slightly different format (I see some > > > > potential to derive a generic parser, based on users described in > > > > Documentation/admin-guide/kernel-parameters.txt), i.e. > > > > > > > > ignore_wake=pin:controller[,pin:controller[,...]] > > > > > > Another possible format > > > > > > ignore_wake=controller@pin[;controller@pin[;...]] > > > > I like this one, the other one with the pin first feels wrong, the pin is > > part of the controller, not the other way around. > > > > I will rework the patch series to use the ignore_wake=controller@pin format. > > Just a quick note. I've changed the separator from ; to , for some reason > grub, at least as used in Fedora with Fedora's grub2 BLS (boot loader spec) > implementation does not like it when there is a ; in the kernel commandline. Hmm... I think it would be harder then to have less possible formats in the command line. Do you really need right now several pins to be listed? If it's about testing, perhaps we may do it with other means. > I will also send an email about this to Fedora grub maintainer, but for > now it is easiest to just avoid the problem. It's definitely bug in Grub due to existing kernel users with such format. It means Grub is unable to support kernel command line in full. -- With Best Regards, Andy Shevchenko
