On Fri, Feb 28, 2020 at 12:22:45PM +0100, Hans de Goede wrote: > On 2/25/20 1:57 PM, Andy Shevchenko wrote: > > On Tue, Feb 25, 2020 at 02:34:25PM +0200, Andy Shevchenko wrote: > > > On Tue, Feb 25, 2020 at 12:26:04PM +0100, Hans de Goede wrote: > > > > > Let's do it as a list of pairs, but in slightly different format (I see some > > > potential to derive a generic parser, based on users described in > > > Documentation/admin-guide/kernel-parameters.txt), i.e. > > > > > > ignore_wake=pin:controller[,pin:controller[,...]] > > > > Another possible format > > > > ignore_wake=controller@pin[;controller@pin[;...]] > > I like this one, the other one with the pin first feels wrong, the pin is > part of the controller, not the other way around. Yes, I agree. > I will rework the patch series to use the ignore_wake=controller@pin format. > > > The second one, while having less users, can be extended to have list of pins > > of the same controller, like > > > > ignore_wake=controller@pin[:pin2:pin3][;controller@pin[:...][;...]] > > I don't really see a need for this, the controller name can be repeated > in the unlikely case where more then one pin needs to be blacklisted > from wakeup and I would like to keep the parsing as KISS as possible. > > I guess we can always add this later if people feel like adding it. Right. -- With Best Regards, Andy Shevchenko
