On Tue, Feb 11, 2020 at 12:49:17PM -0600, Jeremy Linton wrote: > Hi, > > On 2/12/20 7:55 AM, Sudeep Holla wrote: > > On Wed, Feb 12, 2020 at 12:48:33PM +0000, John Garry wrote: > > > On 12/02/2020 11:59, Sudeep Holla wrote: > > > > [...] > > > > > > Yes, as mentioned above. We are not going to do extra work for lazy firmware. > > > > > > I don't think it's reasonable to just label this as lazy. The table may just > > > not have the flag set unintentionally. FW and software guys make mistakes, > > > like the mistakes in PPTT, itself. > > > > > > > We are not talking about flags, it's UID and it is pretty important if > > there are more than one objects of same time. > > But, this hints at my reservations with this approach. If you wanted to have > your processors numbered 0...x and your sockets numbered 0...y, there could > be overlap in the processor container objects, which should also be avoided. > Of course yes, UID needs to be unique at a given processor/container level. Yes, it's more restricted in that way compared to objects of similar type. Here they are all same processor containers, but need to enumerate from 0 at each level. -- Regards, Sudeep