On Tue, Jan 28, 2020 at 7:22 PM John Garry <john.garry@xxxxxxxxxx> wrote: > > On 28/01/2020 17:51, Olof Johansson wrote: > > Hi, > > > > On Tue, Jan 28, 2020 at 3:18 AM John Garry <john.garry@xxxxxxxxxx> wrote: > >> > > Hi Olof, > > >> Add a generic driver for platforms which populate their ACPI PPTT > >> processor package ID Type Structure according to suggestion in the ACPI > >> spec - see ACPI 6.2, section 5.2.29.3 ID structure Type 2. > >> > >> The soc_id is from member LEVEL_2_ID. > >> > >> For this, we need to use a whitelist of platforms which are known to > >> populate the structure as suggested. > >> > >> For now, only the vendor and soc_id fields are exposed. > >> > >> Signed-off-by: John Garry <john.garry@xxxxxxxxxx> > >> --- > >> drivers/soc/Makefile | 1 + > >> drivers/soc/acpi_generic.c | 102 +++++++++++++++++++++++++++++++++++++ > >> 2 files changed, 103 insertions(+) > >> create mode 100644 drivers/soc/acpi_generic.c > >> > >> diff --git a/drivers/soc/Makefile b/drivers/soc/Makefile > >> index 8b49d782a1ab..2a59a30a22cd 100644 > >> --- a/drivers/soc/Makefile > >> +++ b/drivers/soc/Makefile > >> @@ -3,6 +3,7 @@ > >> # Makefile for the Linux Kernel SOC specific device drivers. > >> # > >> > >> +obj-$(CONFIG_ACPI_PPTT) += acpi_generic.o > >> obj-$(CONFIG_ARCH_ACTIONS) += actions/ > >> obj-$(CONFIG_SOC_ASPEED) += aspeed/ > >> obj-$(CONFIG_ARCH_AT91) += atmel/ > > > > Based on everything I've seen so far, this should go under drivers/acpi instead. > > soc drivers seem to live in drivers/soc (non-arm32, anyway), so I > decided on this location. But drivers/acpi would also seem reasonable now. Any reasons for not putting it into drivers/acpi/pptt.c specifically?