Re: [PATCH] PNP: isapnp: remove set but not used variable 'checksum'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 1/3/2020 1:17 PM, yu kuai wrote:
Fixes gcc '-Wunused-but-set-variable' warning:

drivers/pnp/isapnp/core.c: In function ‘isapnp_build_device_list’:
drivers/pnp/isapnp/core.c:777:27: warning: variable ‘checksum’ set
but not used [-Wunused-but-set-variable]

It is never used, and so can be removed.

Signed-off-by: yu kuai <yukuai3@xxxxxxxxxx>
---
  drivers/pnp/isapnp/core.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/pnp/isapnp/core.c b/drivers/pnp/isapnp/core.c
index 179b737280e1..e39d49bceae0 100644
--- a/drivers/pnp/isapnp/core.c
+++ b/drivers/pnp/isapnp/core.c
@@ -774,7 +774,7 @@ static unsigned char __init isapnp_checksum(unsigned char *data)
  static int __init isapnp_build_device_list(void)
  {
  	int csn;
-	unsigned char header[9], checksum;
+	unsigned char header[9];
  	struct pnp_card *card;
  	u32 eisa_id;
  	char id[8];
@@ -784,7 +784,6 @@ static int __init isapnp_build_device_list(void)
  	for (csn = 1; csn <= isapnp_csn_count; csn++) {
  		isapnp_wake(csn);
  		isapnp_peek(header, 9);
-		checksum = isapnp_checksum(header);
  		eisa_id = header[0] | header[1] << 8 |
  			  header[2] << 16 | header[3] << 24;
  		pnp_eisa_id_to_string(eisa_id, id);

Applied as 5.6 material, thanks!

Note that it is recommended to CC patches that touch the PNP code to linux-acpi@xxxxxxxxxxxxxxx





[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux