On Sun, Jan 5, 2020 at 5:04 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > On some laptops enabling wakeup on the GPIO interrupts used for ACPI _AEI > event handling causes spurious wakeups. > > This commit adds a new honor_wakeup option, defaulting to true (our current > behavior), which can be used to disable wakeup on troublesome hardware > to avoid these spurious wakeups. > > This is a workaround for an architectural problem with s2idle under Linux > where we do not have any mechanism to immediately go back to sleep after > wakeup events, other then for embedded-controller events using the standard > ACPI EC interface, for details see: > https://lore.kernel.org/linux-acpi/61450f9b-cbc6-0c09-8b3a-aff6bf9a0b3c@xxxxxxxxxx/ > > One series of laptops which is not able to suspend without this workaround > is the HP x2 10 Cherry Trail models, this commit adds a DMI based quirk > which makes sets honor_wakeup to false on these models. > > Cc: stable@xxxxxxxxxxxxxxx > Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > Acked-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx> > Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> > --- > Changes in v2: > - Use honor_wakeup && ... instead of if (honor_wakeup) ... > - Fix some typos in the comment explaining the need for the quirk Patch applied for fixes. Yours, Linus Walleij
