On Wed, Jan 1, 2020 at 3:52 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > Suspending Goodix touchscreens requires changing the interrupt pin to > output before sending them a power-down command. Followed by wiggling > the interrupt pin to wake the device up, after which it is put back > in input mode. > > On Cherry Trail device the interrupt pin is listed as a GpioInt ACPI > resource so we can do this without problems as long as we release the > irq before changing the pin to output mode. > > On Bay Trail devices with a Goodix touchscreen direct-irq mode is used > in combination with listing the pin as a normal GpioIo resource. This > works fine, but this triggers the WARN in byt_gpio_set_direction-s output > path because direct-irq support is enabled on the pin. > > This commit replaces the WARN call with a dev_info_once call, fixing a > bunch of WARN splats in dmesg on each suspend/resume cycle. > > Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> > --- > Changes in v3: > - Replace WARN with a dev_info_once call, instead of dropping it Patch applied with Mika's ACK! Yours, Linus Walleij
