Where does "ARRAY_SIZE" come from? It's not a part of ACPICA. Bob -----Original Message----- From: zhengbin <zhengbin13@xxxxxxxxxx> Sent: Friday, November 22, 2019 1:33 AM To: Moore, Robert <robert.moore@xxxxxxxxx>; Schmauss, Erik <erik.schmauss@xxxxxxxxx>; Wysocki, Rafael J <rafael.j.wysocki@xxxxxxxxx>; lenb@xxxxxxxxxx; linux-acpi@xxxxxxxxxxxxxxx; devel@xxxxxxxxxx Cc: zhengbin13@xxxxxxxxxx Subject: [PATCH] ACPICA: Use ARRAY_SIZE for 'fadt_info_table','fadt_pm_info_table' Fixes coccicheck warning: drivers/acpi/acpica/tbfadt.c:107:27-28: WARNING: Use ARRAY_SIZE drivers/acpi/acpica/tbfadt.c:137:30-31: WARNING: Use ARRAY_SIZE Reported-by: Hulk Robot <hulkci@xxxxxxxxxx> Signed-off-by: zhengbin <zhengbin13@xxxxxxxxxx> --- drivers/acpi/acpica/tbfadt.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/acpi/acpica/tbfadt.c b/drivers/acpi/acpica/tbfadt.c index 0041bfb..324a804 100644 --- a/drivers/acpi/acpica/tbfadt.c +++ b/drivers/acpi/acpica/tbfadt.c @@ -103,8 +103,7 @@ static struct acpi_fadt_info fadt_info_table[] = { ACPI_FADT_SEPARATE_LENGTH | ACPI_FADT_GPE_REGISTER} }; -#define ACPI_FADT_INFO_ENTRIES \ - (sizeof (fadt_info_table) / sizeof (struct acpi_fadt_info)) +#define ACPI_FADT_INFO_ENTRIES (ARRAY_SIZE(fadt_info_table)) /* Table used to split Event Blocks into separate status/enable registers */ @@ -133,8 +132,7 @@ static struct acpi_fadt_pm_info fadt_pm_info_table[] = { 1} }; -#define ACPI_FADT_PM_INFO_ENTRIES \ - (sizeof (fadt_pm_info_table) / sizeof (struct acpi_fadt_pm_info)) +#define ACPI_FADT_PM_INFO_ENTRIES (ARRAY_SIZE(fadt_pm_info_table)) /******************************************************************************* * -- 2.7.4