On Wed, Nov 06, 2019 at 12:51:09PM +0100, Hans de Goede wrote:
> The Terra Pad 1061 has the usual micro-USB-B id-pin handler, but instead
> of controlling the actual micro-USB-B it turns the 5V boost for the
> tablet's USB-A connector and its keyboard-cover connector off.
>
> The actual micro-USB-B connector on the tablet is wired for charging only,
> and its id pin is *not* connected to the GPIO which is used for the
> (broken) id-pin event handler in the DSDT.
>
> While at it not only add a comment why the Terra Pad 1061 is on the
> blacklist, but also fix the missing comment for the Minix Neo Z83-4 entry.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Thanks!
>
> Fixes: 61f7f7c8f978 ("gpiolib: acpi: Add gpiolib_acpi_run_edge_events_on_boot option and blacklist")
> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> ---
> drivers/gpio/gpiolib-acpi.c | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c
> index 2911dd6f2625..5372652c38eb 100644
> --- a/drivers/gpio/gpiolib-acpi.c
> +++ b/drivers/gpio/gpiolib-acpi.c
> @@ -1307,11 +1307,28 @@ late_initcall_sync(acpi_gpio_handle_deferred_request_irqs);
>
> static const struct dmi_system_id run_edge_events_on_boot_blacklist[] = {
> {
> + /*
> + * The Minix Neo Z83-4 has a micro-USB-B id-pin handler for
> + * a non existing micro-USB-B connector which puts the HDMI
> + * DDC pins in GPIO mode, breaking HDMI support.
> + */
> .matches = {
> DMI_MATCH(DMI_SYS_VENDOR, "MINIX"),
> DMI_MATCH(DMI_PRODUCT_NAME, "Z83-4"),
> }
> },
> + {
> + /*
> + * The Terra Pad 1061 has a micro-USB-B id-pin handler, which
> + * instead of controlling the actual micro-USB-B turns the 5V
> + * boost for its USB-A connector off. The actual micro-USB-B
> + * connector is wired for charging only.
> + */
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Wortmann_AG"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "TERRA_PAD_1061"),
> + }
> + },
> {} /* Terminating entry */
> };
>
> --
> 2.23.0
>
--
With Best Regards,
Andy Shevchenko
