On Sat, Oct 26, 2019 at 10:24:35PM +0200, Hans de Goede wrote: > The Asus T200TA lid has some weird behavior where _LID keeps reporting > closed after every second openening of the lid. Causing immediate > re-suspend after opening every other open. > > I've looked at the AML code but it involves talking to the EC and we > have no idea what the EC is doing. Setting lid_init_state to > ACPI_BUTTON_LID_INIT_OPEN fixes the unwanted behavior, so this commit > adds a DMI based quirk to use ACPI_BUTTON_LID_INIT_OPEN on the T200TA. Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > > Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> > --- > Changes in v2: > - New patch in v2 of this series > --- > drivers/acpi/button.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/acpi/button.c b/drivers/acpi/button.c > index e4b2aa43265b..a090e9542d82 100644 > --- a/drivers/acpi/button.c > +++ b/drivers/acpi/button.c > @@ -77,6 +77,18 @@ MODULE_DEVICE_TABLE(acpi, button_device_ids); > > /* Please keep this list sorted alphabetically by vendor and model */ > static const struct dmi_system_id dmi_lid_quirks[] = { > + { > + /* > + * Asus T200TA, _LID keeps reporting closed after every second > + * openening of the lid. Causing immediate re-suspend after > + * opening every other open. Using LID_INIT_OPEN fixes this. > + */ > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), > + DMI_MATCH(DMI_PRODUCT_NAME, "T200TA"), > + }, > + .driver_data = (void *)(long)ACPI_BUTTON_LID_INIT_OPEN, > + }, > { > /* GP-electronic T701, _LID method points to a floating GPIO */ > .matches = { > -- > 2.23.0 > -- With Best Regards, Andy Shevchenko