Re: [PATCH 07/12] ACPICA: Debugger: add command to dump all fields of a particular subtype

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Erik,

I love your patch! Yet something to improve:

[auto build test ERROR on pm/linux-next]
[cannot apply to v5.4-rc5 next-20191025]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Erik-Schmauss/ACPICA-version-20191018/20191028-014314
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
config: x86_64-randconfig-a002-201943 (attached as .config)
compiler: gcc-6 (Debian 6.3.0-18+deb9u1) 6.3.0 20170516
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

   drivers/acpi/acpica/dbnames.c: In function 'acpi_db_walk_for_fields':
>> drivers/acpi/acpica/dbnames.c:523:2: error: unknown type name 'ACPI_REGION_WALK_INFO'
     ACPI_REGION_WALK_INFO *info = (ACPI_REGION_WALK_INFO *) context;
     ^~~~~~~~~~~~~~~~~~~~~
>> drivers/acpi/acpica/dbnames.c:523:33: error: 'ACPI_REGION_WALK_INFO' undeclared (first use in this function)
     ACPI_REGION_WALK_INFO *info = (ACPI_REGION_WALK_INFO *) context;
                                    ^~~~~~~~~~~~~~~~~~~~~
   drivers/acpi/acpica/dbnames.c:523:33: note: each undeclared identifier is reported only once for each function it appears in
   drivers/acpi/acpica/dbnames.c:523:56: error: expected expression before ')' token
     ACPI_REGION_WALK_INFO *info = (ACPI_REGION_WALK_INFO *) context;
                                                           ^
   drivers/acpi/acpica/dbnames.c:532:10: error: request for member 'address_space_id' in something not a structure or union
         info->address_space_id) {
             ^~
   drivers/acpi/acpica/dbnames.c:536:6: error: request for member 'count' in something not a structure or union
     info->count++;
         ^~
   drivers/acpi/acpica/dbnames.c: In function 'acpi_db_display_fields':
   drivers/acpi/acpica/dbnames.c:721:2: error: unknown type name 'ACPI_REGION_WALK_INFO'
     ACPI_REGION_WALK_INFO info;
     ^~~~~~~~~~~~~~~~~~~~~
   drivers/acpi/acpica/dbnames.c:723:6: error: request for member 'count' in something not a structure or union
     info.count = 0;
         ^
   drivers/acpi/acpica/dbnames.c:724:6: error: request for member 'owner_id' in something not a structure or union
     info.owner_id = ACPI_OWNER_ID_MAX;
         ^
   drivers/acpi/acpica/dbnames.c:725:6: error: request for member 'debug_level' in something not a structure or union
     info.debug_level = ACPI_UINT32_MAX;
         ^
   drivers/acpi/acpica/dbnames.c:726:6: error: request for member 'display_type' in something not a structure or union
     info.display_type = ACPI_DISPLAY_SUMMARY | ACPI_DISPLAY_SHORT;
         ^
   drivers/acpi/acpica/dbnames.c:727:6: error: request for member 'address_space_id' in something not a structure or union
     info.address_space_id = address_space_id;
         ^

vim +/ACPI_REGION_WALK_INFO +523 drivers/acpi/acpica/dbnames.c

   505	
   506	/*******************************************************************************
   507	 *
   508	 * FUNCTION:    acpi_db_walk_for_fields
   509	 *
   510	 * PARAMETERS:  Callback from walk_namespace
   511	 *
   512	 * RETURN:      Status
   513	 *
   514	 * DESCRIPTION: Display short info about objects in the namespace
   515	 *
   516	 ******************************************************************************/
   517	
   518	static acpi_status
   519	acpi_db_walk_for_fields(acpi_handle obj_handle,
   520				u32 nesting_level, void *context, void **return_value)
   521	{
   522		union acpi_object *ret_value;
 > 523		ACPI_REGION_WALK_INFO *info = (ACPI_REGION_WALK_INFO *) context;
   524		struct acpi_buffer buffer;
   525		acpi_status status;
   526		struct acpi_namespace_node *node = acpi_ns_validate_handle(obj_handle);
   527	
   528		if (!node) {
   529			return (AE_OK);
   530		}
   531		if (node->object->field.region_obj->region.space_id !=
   532		    info->address_space_id) {
   533			return (AE_OK);
   534		}
   535	
   536		info->count++;
   537	
   538		/* Get and display the full pathname to this object */
   539	
   540		buffer.length = ACPI_ALLOCATE_LOCAL_BUFFER;
   541		status = acpi_ns_handle_to_pathname(obj_handle, &buffer, TRUE);
   542		if (ACPI_FAILURE(status)) {
   543			acpi_os_printf("Could Not get pathname for object %p\n",
   544				       obj_handle);
   545			return (AE_OK);
   546		}
   547	
   548		acpi_os_printf("%s ", (char *)buffer.pointer);
   549		ACPI_FREE(buffer.pointer);
   550	
   551		buffer.length = ACPI_ALLOCATE_LOCAL_BUFFER;
   552		acpi_evaluate_object(obj_handle, NULL, NULL, &buffer);
   553	
   554		ret_value = (union acpi_object *)buffer.pointer;
   555		switch (ret_value->type) {
   556		case ACPI_TYPE_INTEGER:
   557	
   558			acpi_os_printf("%8.8X%8.8X",
   559				       ACPI_FORMAT_UINT64(ret_value->integer.value));
   560			break;
   561	
   562		case ACPI_TYPE_BUFFER:
   563	
   564			acpi_ut_dump_buffer(ret_value->buffer.pointer,
   565					    ret_value->buffer.length,
   566					    DB_DISPLAY_DATA_ONLY | DB_BYTE_DISPLAY, 0);
   567			break;
   568	
   569		default:
   570	
   571			break;
   572		}
   573	
   574		acpi_os_printf("\n");
   575	
   576		ACPI_FREE(buffer.pointer);
   577		return (AE_OK);
   578	}
   579	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux