On Tue, Oct 01, 2019 at 03:37:08PM +0300, Adrian Hunter wrote: > On 24/09/19 10:37 PM, Andy Shevchenko wrote: > > Since we have a generic helper, drop custom implementation in the driver. > > - if (strcmp(hid, "QCOM8051")) > > + if (acpi_dev_hid_uid_match(adev, "QCOM8051", NULL)) > > Logic is inverted Good catch! I forgot to double check it here while below it's okay... > > - if (strcmp(hid, "QCOM8051")) > > + if (!acpi_dev_hid_uid_match(adev, "QCOM8051", NULL)) -- With Best Regards, Andy Shevchenko