On Tue, Oct 01, 2019 at 12:38:54PM +0300, Mika Westerberg wrote: > On Tue, Sep 24, 2019 at 10:37:36PM +0300, Andy Shevchenko wrote: > > There are users outside of ACPI realm which reimplementing the comparator > > function to check if the given device matches to given HID and UID. > > > > For better utilization, introduce a helper for everyone to use. > > +EXPORT_SYMBOL(acpi_dev_hid_uid_match); > > Should this be _GPL? No, the rest of the acpi_dev_*() are marked without it. > In any case looks good, > > Reviewed-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx> Thanks! -- With Best Regards, Andy Shevchenko