Re: [PATCH] ACPICA: Introduce acpi_load_table_with_index()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 24 Sep 2019, Shevchenko, Andriy wrote:
On Tue, Sep 24, 2019 at 03:07:34PM +0300, Shevchenko, Andriy wrote:
On Mon, Sep 23, 2019 at 11:47:01AM +0200, Nikolaus Voss wrote:
For unloading an ACPI table, it is necessary to provide the
index of the table. The method intended for dynamically
loading or hotplug addition of tables, acpi_load_table(),
does not provide this information, so a new function
acpi_load_table_with_index() with the same functionality,
but an optional pointer to the loaded table index is introduced.

The new function is used in the acpi_configfs driver to save the
index of the newly loaded table in order to unload it later.

I'll test it later, though couple of remarks:
- would it make sense to provide a counter part helper for unloading? Now it
  looks a bit inconsistent in configfs when we use acpi_load_*() vs.
  acpi_tb_*() in remove.

Yes, IMO it would make sense, but it is an ACPICA API change. Bob, what's your opinion?


...and I think we may unexport acpi_tb_* in this case as Bob suggested for it
to be internal API.

see above.


- please, include Ferry into Cc (as done in this mail)




[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux