Hi James, >-----Original Message----- >From: James Morse [mailto:james.morse@xxxxxxx] >Sent: 21 August 2019 18:23 >To: Shiju Jose <shiju.jose@xxxxxxxxxx> >Cc: linux-acpi@xxxxxxxxxxxxxxx; linux-edac@xxxxxxxxxxxxxxx; linux- >kernel@xxxxxxxxxxxxxxx; rjw@xxxxxxxxxxxxx; lenb@xxxxxxxxxx; >tony.luck@xxxxxxxxx; bp@xxxxxxxxx; baicar@xxxxxxxxxxxxxxxxxxxxxx; >Linuxarm <linuxarm@xxxxxxxxxx>; Jonathan Cameron ><jonathan.cameron@xxxxxxxxxx>; tanxiaofei <tanxiaofei@xxxxxxxxxx> >Subject: Re: [PATCH RFC 2/4] ACPI: APEI: Add ghes_handle_memory_failure to >the new notification method > >Hi, > >On 12/08/2019 11:11, Shiju Jose wrote: >> This patch adds ghes_handle_memory_failure to the new error >> notification method. > >The commit message doesn't answer the question: why? > >The existing code works. This just looks like additional churn. >Given a user, I think the vendor specific example is useful. I don't think making >this thing more pluggable is a good idea. This was intended to replace the number of if(guid_equal(...)) else if(guid_equal(...)) checks in the ghes_do_proc() , which would grow when new UEFI defined error sections would be added in the future. > > >Thanks, > >James Thanks, Shiju
