On Tue, Jul 09, 2019 at 03:11:15PM +0000, Mario.Limonciello@xxxxxxxx wrote: > > -----Original Message----- > > From: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx> > > Sent: Friday, July 5, 2019 5:58 AM > > To: Yehezkel Bernat > > Cc: LKML; Andreas Noever; Michael Jamet; Rafael J . Wysocki; Len Brown; Lukas > > Wunner; Limonciello, Mario; Anthony Wong; linux-acpi@xxxxxxxxxxxxxxx > > Subject: Re: [PATCH 2/8] thunderbolt: Move NVM upgrade support flag to struct > > icm > > > > > > [EXTERNAL EMAIL] > > > > On Fri, Jul 05, 2019 at 01:52:49PM +0300, Yehezkel Bernat wrote: > > > > @@ -2054,6 +2059,7 @@ struct tb *icm_probe(struct tb_nhi *nhi) > > > > case PCI_DEVICE_ID_INTEL_TITAN_RIDGE_2C_NHI: > > > > case PCI_DEVICE_ID_INTEL_TITAN_RIDGE_4C_NHI: > > > > icm->max_boot_acl = ICM_AR_PREBOOT_ACL_ENTRIES; > > > > + icm->can_upgrade_nvm = true; > > > > > > Shouldn't this be also !x86_apple_machine just like AR? > > > (For FR, we don't use ICM on Apple machines, as much as I remember, so it's fine > > > to enable it there unconditionally for ICM code path.) > > > > Yes, good point. I'll fix it up. > > Another thought - does the TR or AR ID's setting can_upgrade_nvm to !x86_apple_machine > show up in anything like a dock or is it only host controllers? If it's in docks, then it might be worth > only blocking on apple if it's a host. It affects only hosts so on Apple system you can't upgrade host NVM but docks and other devices you can.
